chore(release): v4.8.0 #4146
Merged
chore(release): v4.8.0 #4146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chore: merge master into develop
… pages (#4026) * perf(get-element-stack): improve getElementStack performance on large pages * use memoize instead of cache in getScroll
* test: refactor get-background-color tests with color asserts * test: normalize background colors in get-background-color hooks * test: refactor and improve assert output in assertRectsEqual * test: fix integration test server ipv6 compat * test: normalize background colors in get-foreground-color hooks * test: fix light-mode color assumption in dialog integration test * resolve PR comments
* Update: add meter to allowed roles for named img closes #4054 * fix spacing * add meter img test * Update test/integration/rules/aria-allowed-role/aria-allowed-role.html * Update aria-allowed-role.json
…4060) * fix: avoid problems from element IDs that exist on object prototype * 🤖 Automated formatting fixes * Fixed tests
* fix: ensure better cleanup after t * 🤖 Automated formatting fixes * Fix tests * Resolve feedback
* feat: deprecate & disable duplicate-id / duplicate-id-active * Use wcag2a-obsolete tag
* feat: add EN.301.549 tags to rules * Add proper tag validation * Docs * Update tag validation * Change to "EN-301-549"
…ontext (#4072) * fix(utils/clone): don't try to clone elements from different window context * weakmap * don't use cache between calls * use strict equal * use strict equal * cache * create on internal * typo
* feat: add rule aria-deprecated-role * more tests * Update lib/rules/aria-deprecated-role.json Co-authored-by: Wilco Fiers <WilcoFiers@users.noreply.github.com> * run build --------- Co-authored-by: Wilco Fiers <WilcoFiers@users.noreply.github.com>
…lement (#4083) * Add doc-glossary to allowed roles for aside element updates html-elms.js * Update aria-allowed-role.html adds doc-glossary passing example * Update aria-allowed-role.json adds pass-aside-doc-glossary to match aria-allowed-role.html ID
* fix(color-contrast): correctly handle flex and position * typos * indentation * tests
* fix(color-contrast): get text stoke from offset shadows * Apply suggestions from code review Co-authored-by: Dan Bjorge <dan.bjorge@deque.com> * Refactor & cleanup * Have partial text-shadows report as incomplete * Ignore thin shadows on one side of text * Resolve feedback --------- Co-authored-by: Dan Bjorge <dan.bjorge@deque.com>
* chore: enable eslint:no-shadow * moar * finalize * fix * Apply suggestions from code review Co-authored-by: Stephen Mathieson <571265+stephenmathieson@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: Wilco Fiers <WilcoFiers@users.noreply.github.com> * 🤖 Automated formatting fixes --------- Co-authored-by: Stephen Mathieson <571265+stephenmathieson@users.noreply.github.com> Co-authored-by: Wilco Fiers <WilcoFiers@users.noreply.github.com> Co-authored-by: straker <straker@users.noreply.github.com>
* feat(aria-prohibited-attr): add rule aria-prohibited-attr * fix act * fixes * Apply suggestions from code review Co-authored-by: Wilco Fiers <WilcoFiers@users.noreply.github.com> --------- Co-authored-by: Wilco Fiers <WilcoFiers@users.noreply.github.com>
* fix(d.ts): target selector type for shadow dom Before shadow dom support string[] was the correct type for the returned selectors. From code we can see that SerialDqElement.selector is used to populate this, so the type should also be the same. * feat(d.ts): add missing properties to the RelatedNode interface RelatedNode should have the same selectors and the same element reference as NodeResult. These are populated in process-aggregate.js. * fix(d.ts): incomplete message should be optional I think this was unintentionally changed in #3966. From check definitions we can see that many of them don't specify the incomplete message, because they don't have incomplete as a possible result. * feat(d.ts): add stronger typing to Check evaluate and after functions More precise types make it easier to write these function in typescript. With this change, complier knows about this.data, this.async, etc. * feat(d.ts): allow rule.matches to be a function Like evaluate and after, matches can also be a string or a function, but this is not currently represented in types. * fix(d.ts): tags and actIds should be on Rule and not RuleMetadata The rule metadata object expected in this.configure and the one returned by getRules are not the same. From the code we can see that tags and actIds are read from the rule itself and not from the metadata object. * feat(d.ts): add types for more utils and commons functions
…copeFilter, take into ancestors with sectioning roles (#4105) * fix(page-no-duplicate-banner/contentinfo): take into account elements which have ancestors with sectioning roles * integration tests
* fix(color-contrast): ignore format unicode characters * comment * typo * Apply suggestions from code review Co-authored-by: Wilco Fiers <WilcoFiers@users.noreply.github.com> --------- Co-authored-by: Wilco Fiers <WilcoFiers@users.noreply.github.com>
* fix(aria-required-childen): test visibility of grandchildren * Little refactoring * More refactoring * Apply suggestions from code review Co-authored-by: Steven Lambert <2433219+straker@users.noreply.github.com> * 🤖 Automated formatting fixes --------- Co-authored-by: Steven Lambert <2433219+straker@users.noreply.github.com>
* fix(color-contrast): process non-rgb color functions * Update lib/commons/color/parse-text-shadows.js Co-authored-by: Steven Lambert <2433219+straker@users.noreply.github.com> * 🤖 Automated formatting fixes --------- Co-authored-by: Steven Lambert <2433219+straker@users.noreply.github.com>
… of an element to the grid (#4101) * fix(commons/dom/createGrid): only add the visible, non-overflow areas of an element to the grid * integration test * Update test/integration/full/contrast/memory.html Co-authored-by: Wilco Fiers <WilcoFiers@users.noreply.github.com> --------- Co-authored-by: Wilco Fiers <WilcoFiers@users.noreply.github.com>
* fix: Use correct copyright year This patch corrects the copyright year included in the built `axe.js` and `axe.min.js` files. Deque Systems, Inc has held the copyright for axe-core since 2015. * Update lib/intro.stub Co-authored-by: Wilco Fiers <WilcoFiers@users.noreply.github.com> --------- Co-authored-by: Wilco Fiers <WilcoFiers@users.noreply.github.com>
* feat: add rule aria-conditional-attr * Virtual rule tests * Text tweaks aria-conditional-attr --------- Co-authored-by: Steven Lambert <2433219+straker@users.noreply.github.com>
…braille attributes (#4107) * feat(new-rule): aria-braille-equivalent finds incorrect uses of aria-braille attributes * Fix test * More tests * Resolve feedback
* chore: modernized rule generator * Resolve feedback
…-valuetext (#4109) * fix(aria-valid-attr-value): allow empty value on aria-braille* & aria-valuetext * Fix test * Fix tests
* feat: Deprecate impact on checks, use rules instead * Update docs
* fix(jsdom): allow axe.setup() without a global window * Caps matter, silly willy
* feat: allow reporters to error * fix(reporter): reject handle for consistent error processing
* fix(color-contrast): ignore zero width characters * fix * replace affirm font with purpose built zero width 0 char font * Update lib/commons/text/is-icon-ligature.js Co-authored-by: Dan Bjorge <dan.bjorge@deque.com> --------- Co-authored-by: Dan Bjorge <dan.bjorge@deque.com>
* update role allowances for aria-expanded All roles reviewed to largely remove (but in a few cases add) `aria-expanded` as a supported attribute. This matches both work done in ARIA 1.2 to correct for roles that should not have allowed the attribute, while also incorporating some ARIA 1.2 updates where some roles had support for the attribute added. closes #3339 * fix(aria-allowed-attr): allow aria-expanded on more roles * Integration tests * Update lib/standards/aria-roles.js Co-authored-by: Steven Lambert <2433219+straker@users.noreply.github.com> * Tweak comments --------- Co-authored-by: Scott O'Hara <scottaohara@users.noreply.github.com> Co-authored-by: Steven Lambert <2433219+straker@users.noreply.github.com>
* fix(target-size): update to match new spacing requirements * working * tests * finalize? * tests * revert playground * 🤖 Automated formatting fixes * Apply suggestions from code review Co-authored-by: Wilco Fiers <WilcoFiers@users.noreply.github.com> * 🤖 Automated formatting fixes * udpate tests * dont half minOffset but double return from getOffset * Apply suggestions from code review Co-authored-by: Wilco Fiers <WilcoFiers@users.noreply.github.com> * 🤖 Automated formatting fixes * fix tests * fix test --------- Co-authored-by: straker <straker@users.noreply.github.com> Co-authored-by: Wilco Fiers <WilcoFiers@users.noreply.github.com>
* chore(aria-braille-equivalent): Update to be reviewOnFail * Virtual tests
* fix(dialog-name): get name from header elements * Never get content from elements with a value * Fix failing test * Grrr, prettier * More tests * Update test/testutils.js
* fix(target-size): correctly calculate bounding box * test rectHasMinimumSize * return early * comment and refactor * text * use neighbor target size * suggestions * fix bug
* DqElement.setSerializer initial impl * implemented and passing integration tests * Separated nodeSerializer * Cleanup & tests * prevent html: "Undefined" when noHtml is set * Update test/core/public/run-partial.js * Tweaks * Change to nodeSerializer.update * WIP: Delay DqElement serialization * Delay node serialization * Tweak * Simplify a bit further * Cleanup * Improve performance * Update raw reporter * DqElement in checkHelper * Update lib/core/utils/check-helper.js Co-authored-by: Steven Lambert <2433219+straker@users.noreply.github.com> * Update lib/core/utils/dq-element.js * Update lib/core/utils/node-serializer.js Co-authored-by: Steven Lambert <2433219+straker@users.noreply.github.com> --------- Co-authored-by: Wilco Fiers <wilco.fiers@deque.com> Co-authored-by: Wilco Fiers <WilcoFiers@users.noreply.github.com> Co-authored-by: Steven Lambert <2433219+straker@users.noreply.github.com>
Change \"role=text\" to role=\"text\"
* Chore(i18n): Update and correct Japanese translation Remove whitespaces between English words and Japanese characters as agreed previously: #3319 rules/accesskeys: wording change rules/aria-focus-hidden: wording change rules/aria-input-field-name/help: wording change rules/aria-roledescription/help: wording change rules/aria-text/description: make the location of the double-quotes consistent with the original text. rules/aria-toggle-field-name/help: change wording rules/aria-tooltip-name/description: wording change rules/aria-treeitem-name/description: wording changes rules/blink/help: correct translation rules/color-contrast-enhanced: correct translation rules/color-contrast: correct translation rules/css-orientation-lock/help: wording change rules/definition-list/help: correct translation rules/duplicate-id-active: wording changes rules/duplicate-id-aria/description: wording change rules/focus-order-semantics: correct translation rules/form-field-multiple-labels/help: wording change rules/frame-focusable-content: correct translation rules/frame-tested/help: change wording rules/frame-title: correct translation rules/hidden-content* correct translation rules/identical-links-same-purpose: correct translation rules/label-title-only/description: correct translation rules/landmark-complementary-is-top-level/help: wording change rules/landmark-one-main/description: correct translation rules/landmark-unique/description: correct translation. rules/link-in-text-block: correct translation rules/meta-refresh-no-exceptions: correct translation rules/meta-refresh: correct translation rules/meta-viewport-large/help: correct translation rules/meta-viewport: correct translation rules/nested-interactive: correct translation rules/no-autoplay-audio/help: correct translation rules/p-as-heading: correct translation rules/presentation-role-conflict: correct translation rules/role-img-alt: correct translation rules/scrollable-region-focusable: correct translation rules/svg-img-alt/help: correct translation rules/tabindex/help: correct translation rules/table-duplicate-name: correct translation rules/table-fake-caption/help: correct translation rules/target-size/help: correct translation rules/td-has-header: correct translation rules/td-headers-attr: correct translation rules/th-has-data-cells: swap the content of help and description to be consistent with the original. checks/aria-allowed-attr/incomplete: correct translation checks/aria-allowed-role/{fail,incomplete: correct translation checks/aria-busy/fail: correct translation checks/aria-errormessage{pass,fail}: correct translation checks/aria-required-children/fail/unallowed: sync with the en version checks/aria-allowed-attr/incomplete: correct translation checks/deprecatedrole/pass: correct translation checks/has-global-aria-attribute: correct translation checks/color-contrast-enhanced/incomplete/pseudoContent: consistent wording with other phrases checks/color-contrast/incomplete/pseudoContent: consistent wording with other phrases checks/pseudoContent/pass: consistent wording with other phrases checks/link-in-text-block/incomplete/{default,bgColorContrast}: correct translation checks/accesskeys: correct translation checks/focusable-disabled: correct translation checks/focusable-modal-open: correct translation checks/focusable-not-tabbable: correct translation checks/landmark-is-top-level/fail: correct translation checks/page-has-main/pass: correct translation checks/alt-space-value/fail: correct translation checks/explicit-label: correct translation checks/help-same-as-label: correct translation checks/hidden-explicit-label: correct translation checks/multiple-label/fail: correct translation checks/landmark-is-unique/pass: correct translation checks/listitem/fail/roleNotValid: correct translation checks/only-dlitems: correct translation checks/only-listitems: correct translation checks/caption/incomplete: correct translation checks/no-autoplay-audio: correct translation checks/css-orientation-lock: correct translation checks/target-offset: correct translation checks/target-size: correct translation checks/header-present: correct translation checks/identical-links-same-purpose/incomplete: correct translation checks/identical-links-same-purpose: correct translation Make the translation of the oword "present" consistent throughout the file. checks/meta-refresh-no-exceptions/fail: correct translation checks/meta-refresh/fail: correct translation checks/p-as-heading/fail: correct translation checks/duplicate-id-aria: correct translation checks/duplicate-id: correct translation checks/button-has-visible-text/{pass,fail}: correct translation checks/has-alt: correct translation checks/important-letter-spacing: correct translation checks/important-line-height: correct translation checks/important-word-spacing: correct translation checks/non-empty-alt/pass: correct translation checks/non-empty-if-present: correct translation checks/non-empty-placeholder: correct translation checks/non-empty-title: correct translation checks/non-empty-value: correct translation checks/presentational-role: correct translation checks/svg-non-empty-title: correct translation checks/caption-faked/pass: typo fix failureSummary/incompleteFallbackMessage: correct translation Make the translation for "role attribute" consistent throughout the file. Add ja translation for checks/aria-conditional-attr * Add translation for checks/link-in-text-block-style/incomplete * Add ja translation for rules/aria-deprecated-role * Add ja translation for checks/color-contrast/incomplete/complexTextShadows * Update locales/ja.json Co-authored-by: Wilco Fiers <WilcoFiers@users.noreply.github.com> * checks/aria-allowed-role/imcomplete: make the wording consistent between singular and plural * Add translation for rules/aria-prohibited-attr * Add translations for rules/aria-braille-equivalent, rules/aria-conditional-attr, checks/braille-label-equivalent, and checks/braille-roledescription-equivalent * Update locales/ja.json Co-authored-by: Wilco Fiers <WilcoFiers@users.noreply.github.com> * Update checks/braille-roledescription-equivalent/pass to make it inline with the changes introduced by PR #4133 * Correct the error in the previous commit. --------- Co-authored-by: Masafumi Max NAKANE <ma10@users.noreply.github.com> Co-authored-by: Wilco Fiers <WilcoFiers@users.noreply.github.com>
…4144) * Replace name='value' with name=\"value\" * don't enclose name=value in single quotes
* chore(i18n): Update pl.json * minor text revision * modified as suggested: * 1. the texts of the help and descriptions have been synchronised 2. redundant characters "`" removed 3. updated to latest version 4.7.2 * Update locales/pl.json Co-authored-by: Wilco Fiers <WilcoFiers@users.noreply.github.com> * revert `input-image-alt` as requested * minor corect --------- Co-authored-by: Wojciech Smoliński <wojsmol@wp.pl> Co-authored-by: Wilco Fiers <WilcoFiers@users.noreply.github.com>
* fix: ignore stylesheets fetching when is a inline style * chore: update comment for jsdom issue Co-authored-by: Steven Lambert <2433219+straker@users.noreply.github.com> --------- Co-authored-by: Steven Lambert <2433219+straker@users.noreply.github.com>
WilcoFiers
approved these changes
Sep 6, 2023
There was a problem hiding this comment.
Release Audit
- test: fix implicit test dependencies on local dev environment #4053
- fix: avoid memory issues by doing better cleanup #4059
- fix(utils/clone): don't try to clone elements from different window context #4072
- feat(impact): scope-attr-valid is always "moderate" #4113
- chore(aria-braille-equivalent): Update to be reviewOnFail #4123
- fix: ignore stylesheets fetching when is a inline style #4138 (comment)
|
Reviewed for security. Not sure why the Security review thing is busted. Had to bypass. |
|
reviewed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
4.8.0 (2023-09-06)
Features
Bug Fixes
This PR was opened by a robot 🤖 🎉